D24305: [Cuttlefish] Compare an icon in different themes

Nathaniel Graham noreply at phabricator.kde.org
Tue Oct 1 12:49:09 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> davidre wrote in Comparison.qml:70
> That's what I did first acutally but I didn't like that for two reasons. First it would scale with the other icons and when you are looking at paint-none you couldn't distinguish it anymore.

In that case what about just setting ` color: Kirigami.Theme.disabledTextColor` when there's no icon? That should serve to distinguish the actual `paint-none` icon from the use of that icon to denote "no icon available"

I don't think having it scale is a huge deal.

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191001/b5cb858f/attachment.html>


More information about the Plasma-devel mailing list