D25566: [Notifications] Move out of the way of dialog rather than just hiding
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Nov 27 15:48:43 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
When e.g. connecting to a network with captive portal, it leaves you sitting there wondering what's going on. The notification won't time out until it becomes visible again but still there's been complaints that the notifications go missing.
This patch makes them move out of the way vertically. It is pretty crude but covers the majority ("System Tray covers notifications") case.
TEST PLAN
F7786935: 30ae33e9-8334-4928-8945-94371990c379.mp4 <https://phabricator.kde.org/F7786935>
When there's many notifications, it can look a bit odd as they move down and then the lower part is hidden as notifications may only occupy 2/3 of vertical height even when shifted.
Didn't test what happens if you have a giant notification on a small screen, it will probably end up partially off screen
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25566
AFFECTED FILES
applets/notifications/package/contents/ui/global/Globals.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191127/e4ea54ac/attachment.html>
More information about the Plasma-devel
mailing list