D25543: Split Style & Helper into files by widget type

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  You are missing copyright information and license in all the newly created files. 
  On the review side: it is impossible to actually review, right ? 
  As for the conceptual side: I fear this is addressing a non existing issue, and giving a wrong impression about how one should hack on a widget style. It is wrong to think that you can hack on a widget style widget by widget without consideration about how they should appear one with respect to the others, how they should align one with respect to the other, and how the other widgets are implemented. You do need to know the whole code and interplay before starting to hack anyway. The splitting does not change this. In the end it might just result in a lot of duplicated code.
  
  Anyway. I wont prevent you for pushing this. Who does the job decides. This probably marks the end of my contributions to breeze though, but they have not been that many lately anyway.
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191127/f02e7eb0/attachment-0001.html>