D25539: feat(kcm): add revert timer

Zixing Liu noreply at phabricator.kde.org
Wed Nov 27 02:07:48 GMT 2019


liushuyu marked 2 inline comments as done.
liushuyu added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:32
> Doesn't seem to be used; the timer duration is hardcoded on the C++ side

Now, it's used by the Timer

> ngraham wrote in main.qml:110
> I would change these to `StandardButton.Apply` and `StandardButton.Discard`

Now InlineMessage is used

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25539

To: liushuyu, #vdg, #plasma, romangg
Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191127/f86211ac/attachment.html>


More information about the Plasma-devel mailing list