D25543: Split Style & Helper into files by widget type
Nathaniel Graham
noreply at phabricator.kde.org
Tue Nov 26 22:37:31 GMT 2019
ngraham added a comment.
Ah whoops, I missed the huge `kstyle/breezestyle.cpp` diff because it was collapsed.
Conceptually this makes sense to me and I can spot no visual regressions resulting from it. No formal acceptance from me yet because I feel like this requires more eyes, and we should probably keep it open for a while to make sure everything has gotten moved properly.
Great work though! I think this will really make it easier to contribute to Breeze.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D25543
To: ndavis, #plasma, #breeze
Cc: hpereiradacosta, ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191126/64608e20/attachment-0001.html>
More information about the Plasma-devel
mailing list