D25543: Split Style & Helper into files by widget type

Noah Davis noreply at phabricator.kde.org
Tue Nov 26 21:53:03 GMT 2019


ndavis added a comment.


  In D25543#567838 <https://phabricator.kde.org/D25543#567838>, @ngraham wrote:
  
  > Very nice, I applaud the goal. However it looks like on net a lot more lines of code were added than were removed, which suggests the addition of redundant boilerplate or unrelated style refactoring. In the former case, can we factor out some of it into additional helper functions?
  
  
  I didn't add any new lines of code, I just moved them into other files. I did format the new files in `widgets/`, but not the existing files.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25543

To: ndavis, #plasma, #breeze
Cc: ngraham, IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191126/ef349364/attachment.html>


More information about the Plasma-devel mailing list