D25522: KCM Colors : take into account immutable property

Kevin Ottens noreply at phabricator.kde.org
Tue Nov 26 10:30:46 GMT 2019


ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a tiny style issue, otherwise LGTM.

INLINE COMMENTS

> colors.h:51
>      Q_PROPERTY(FilterProxyModel *filteredModel READ filteredModel CONSTANT)
> +    Q_PROPERTY(ColorsSettings* colorsSettings READ colorsSettings CONSTANT)
>      Q_PROPERTY(bool downloadingFile READ downloadingFile NOTIFY downloadingFileChanged)

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25522

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191126/2cb3b184/attachment-0001.html>


More information about the Plasma-devel mailing list