D25539: KScreen KCM: Add a revert timer to the settings page
Zixing Liu
noreply at phabricator.kde.org
Tue Nov 26 04:01:17 GMT 2019
liushuyu created this revision.
liushuyu added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
liushuyu requested review of this revision.
REVISION SUMMARY
Add a revert timer and an option for the user to revert the settings when they accidentally messed up the settings and unable to see the screen.
The current implementation is very rudimentary, a message box is shown and the text is static (no countdown in the dialog box).
F7784367: 2019-11-25_20-46.png <https://phabricator.kde.org/F7784367>
F7784366: 2019-11-25_20-46_1.png <https://phabricator.kde.org/F7784366>
TEST PLAN
1. Open the System Settings and navigate to the "Display and Monitor" -> "Display Configuration."
2. Change any settings and hit Apply.
3. Don't click on the pop-up, wait for 10 seconds and see if the changes will be reverted and the dialog box closed.
4. Repeat step 1 to step 2 and this time, click "cancel" and see if the changes will be reverted and the dialog box closed.
5. Repeat step 1 to step 2 but this time click "save" and see if the changes will be saved and the dialog box closed, wait for 10 seconds to see if the changes are still retained.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D25539
AFFECTED FILES
kcm/config_handler.cpp
kcm/config_handler.h
kcm/kcm.cpp
kcm/kcm.h
kcm/package/contents/ui/main.qml
To: liushuyu, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191126/515abf6e/attachment.html>
More information about the Plasma-devel
mailing list