D25526: KCM launch feedback : take into account immutable properties

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Nov 25 15:37:20 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> main.qml:45
>  
> +            enabled: formLayout.cursorImmutable
>              Kirigami.FormData.label: i18n("Cursor:")

Imho this is confusing.
The property should be `readonly property bool cursorImmutable: kcm.setings.immutable && ..` and then this would be `enabled: !immutable`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25526

To: crossi, ervin, bport, mart, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191125/302a9f4e/attachment.html>


More information about the Plasma-devel mailing list