D25430: fix layout of overlaysheet

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Nov 21 15:14:42 GMT 2019


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Change looks good to me. Please resolve the comments before landing.

INLINE COMMENTS

> DummyTransaction.cpp:52
>          setProgress(qBound(0, progress()+(KRandom::random()%30), 100));
> -        QTimer::singleShot(/*KRandom::random()%*/100, this, &DummyTransaction::iterateTransaction);
> +        QTimer::singleShot(/*KRandom::random()%*/1000, this, &DummyTransaction::iterateTransaction);
>      } else if (status() == DownloadingStatus) {

Please don't change this because this will make tests much slower.

REPOSITORY
  R134 Discover Software Store

BRANCH
  phab/overlaysheet

REVISION DETAIL
  https://phabricator.kde.org/D25430

To: mart, #discover_software_store, apol
Cc: apol, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191121/767198e9/attachment-0001.html>


More information about the Plasma-devel mailing list