D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.


  This is what happens when icon size is set to 32px or more (48px here): F7776520: Screenshot_20191121_062030.png <https://phabricator.kde.org/F7776520>
  `size.setHeight(toolButtonOption->fontMetrics.height());` doesn't take icon size into account.
  Also, still -1 to making flat buttons and non-flat buttons the same size at the same icon sizes in //this// patch. That change has potential consequences that can reach much farther than the button vs line edit height inconsistency that originally needed to be solved.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma, ngraham, ndavis
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191121/4b136a7f/attachment.html>