D25398: Check values have changed before setting the model

[Méven Car]

meven added a comment.


  In D25398#564887 <https://phabricator.kde.org/D25398#564887>, @ngraham wrote:
  
  > In D25398#564843 <https://phabricator.kde.org/D25398#564843>, @meven wrote:
  >
  > > I had a look at the others :
  > >
  > > > - https://bugs.kde.org/show_bug.cgi?id=392943
  > > > - https://bugs.kde.org/show_bug.cgi?id=389878
  > > > - https://bugs.kde.org/show_bug.cgi?id=393702
  > >
  > > Something I noticed when having an avatar and setting any other parameter.
  > >  Apparently AccountService removes the icon as it considered it transient cache data :
  > >  https://github.com/magcius/accountsservice/blob/eb166ec7592704a897594f7ca4c47b70d871a85c/src/daemon.c#L1105
  >
  >
  > So it's an upstream issue? Is that really where upstream AccountsService lives? Some random guy's GitHub?
  
  
  This was a clone of an old version.
  
  Current behavior is the same in the current version.
  https://cgit.freedesktop.org/accountsservice/tree/src/daemon.c#n155
  Apparently the accountservice daemon wants to uncache the user and in doing so delete data without updating its internal reference.
  
  GNOME does the same as our user-manager but I guess it is not affected.
  https://github.com/GNOME/gnome-control-center/blob/f5f67823db5a629fa3ce618bc1d8b80d14f1fc59/panels/user-accounts/cc-avatar-chooser.c#L87
  
  I did some digging but could not pinpoint the problem origin.
  
  In the meantime, I believe this diff is worth merging and might be useful for stable branch even.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D25398

To: meven, #plasma
Cc: ngraham, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191120/32459b70/attachment.html>