D25395: Make avatar icon dpr aware aka HiDPI rendered

Cyril Rossi noreply at phabricator.kde.org
Tue Nov 19 14:48:04 GMT 2019


crossi added inline comments.

INLINE COMMENTS

> accountmodel.cpp:545
> +void AccountModel::setDpr(qreal dpr) {
> +    this->dpr = dpr;
> +}

See my previous comment, 'this->' prefix won't be necessary.

> accountmodel.h:95
>          AutomaticLoginSettings m_autoLoginSettings;
> +        qreal dpr = 1;
>  };

Style related, attribute member are prefixed with 'm_', see above declarations.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D25395

To: meven, #plasma
Cc: crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191119/4ab5f44a/attachment.html>


More information about the Plasma-devel mailing list