D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

Jan Grulich noreply at phabricator.kde.org
Mon Nov 18 08:40:45 GMT 2019


jgrulich added a comment.


  In D25279#562998 <https://phabricator.kde.org/D25279#562998>, @ngraham wrote:
  
  > Hmm, reading the code more closely, it looks like it should already work. In fact, when I remove all my changes... it does work! I could have sworn that it didn't work before though.
  >
  > Does this make any sense? Could it have been fixed by 7dd740aa963057c255fbbe83366504bbe48a240e <https://phabricator.kde.org/R116:7dd740aa963057c255fbbe83366504bbe48a240e>?
  
  
  Not sure whether the change mentioned above, but it should indeed work just fine. The "else if" branch checks whether an adapter was enabled before so it does what it's supposed to do.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191118/1bcae66c/attachment.html>


More information about the Plasma-devel mailing list