D22684: [Klipper] Fix clipboard history management

[Piotr Dabrowski]

pdabrowski added inline comments.

INLINE COMMENTS

> davidedmundson wrote in historyimageitem.cpp:45
> what's this square about?
> 
> Also if "bpp" is bits per pixel, we need to put it in i18n() for translation

The square indicates that the clipboard contains an image, not a literal string like "1920x1080 32bpp".

> i18n()

Done.

> ngraham wrote in historyimageitem.cpp:65
> Does this have to be a pixmap? Can it just be a QIcon instead?

This is overridden from HistoryItem parent class.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191117/253a0884/attachment-0001.html>