D22684: [Klipper] Fix clipboard history management

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> historyimageitem.cpp:65
>  
> +const QPixmap& HistoryImageItem::image() const {
> +    if (m_model->displayImages()) {

Does this have to be a pixmap? Can it just be a QIcon instead?

> historyimageitem.cpp:70
> +    static QPixmap imageIcon(
> +        QIcon::fromTheme(QStringLiteral("viewimage")).pixmap(QSize(48, 48))
> +    );

use the `view-preview` icon instead

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22684

To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson
Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191115/5e32fd33/attachment.html>