D25191: replace bespoke xkb geometry parser with xkb

Harald Sitter noreply at phabricator.kde.org
Fri Nov 15 11:36:01 GMT 2019


sitter updated this revision to Diff 69799.
sitter added a comment.


  - remove all color mapping tech, it's pointless since the code now uses the system palette
  - remove garbage foobar class
  - remove unnecessary main.moc include
  - create two global SystemPalettes instead of in individual items

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25191?vs=69752&id=69799

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25191

AFFECTED FILES
  kcms/keyboard/CMakeLists.txt
  kcms/keyboard/config-keyboard.h.cmake
  kcms/keyboard/kcm_add_layout_dialog.cpp
  kcms/keyboard/kcm_add_layout_dialog.h
  kcms/keyboard/kcm_keyboard_widget.cpp
  kcms/keyboard/kcm_keyboard_widget.h
  kcms/keyboard/preview/TODO
  kcms/keyboard/preview/geometry_components.cpp
  kcms/keyboard/preview/geometry_components.h
  kcms/keyboard/preview/geometry_parser.cpp
  kcms/keyboard/preview/geometry_parser.h
  kcms/keyboard/preview/kbpreviewframe.cpp
  kcms/keyboard/preview/kbpreviewframe.h
  kcms/keyboard/preview/keyaliases.cpp
  kcms/keyboard/preview/keyaliases.h
  kcms/keyboard/preview/keyboardlayout.cpp
  kcms/keyboard/preview/keyboardlayout.h
  kcms/keyboard/preview/keyboardpainter.cpp
  kcms/keyboard/preview/keyboardpainter.h
  kcms/keyboard/preview/keysym2ucs.cpp
  kcms/keyboard/preview/keysym2ucs.h
  kcms/keyboard/preview/keysymbols.cpp
  kcms/keyboard/preview/keysymbols.h
  kcms/keyboard/preview/keysymhelper.cpp
  kcms/keyboard/preview/keysymhelper.h
  kcms/keyboard/preview/symbol_parser.cpp
  kcms/keyboard/preview/symbol_parser.h
  kcms/keyboard/tastenbrett.cpp
  kcms/keyboard/tastenbrett.h
  kcms/keyboard/tastenbrett/CMakeLists.txt
  kcms/keyboard/tastenbrett/README.md
  kcms/keyboard/tastenbrett/application.cpp
  kcms/keyboard/tastenbrett/application.h
  kcms/keyboard/tastenbrett/doodad.cpp
  kcms/keyboard/tastenbrett/doodad.h
  kcms/keyboard/tastenbrett/geometry.cpp
  kcms/keyboard/tastenbrett/geometry.h
  kcms/keyboard/tastenbrett/key.cpp
  kcms/keyboard/tastenbrett/key.h
  kcms/keyboard/tastenbrett/main.cpp
  kcms/keyboard/tastenbrett/outline.cpp
  kcms/keyboard/tastenbrett/outline.h
  kcms/keyboard/tastenbrett/qml.qrc
  kcms/keyboard/tastenbrett/qml/IndicatorDoodad.qml
  kcms/keyboard/tastenbrett/qml/Key.qml
  kcms/keyboard/tastenbrett/qml/KeyCap.qml
  kcms/keyboard/tastenbrett/qml/KeyCapLabel.qml
  kcms/keyboard/tastenbrett/qml/ShapeCanvas.qml
  kcms/keyboard/tastenbrett/qml/ShapeDoodad.qml
  kcms/keyboard/tastenbrett/qml/TextDoodad.qml
  kcms/keyboard/tastenbrett/qml/main.qml
  kcms/keyboard/tastenbrett/row.cpp
  kcms/keyboard/tastenbrett/row.h
  kcms/keyboard/tastenbrett/section.cpp
  kcms/keyboard/tastenbrett/section.h
  kcms/keyboard/tastenbrett/shape.cpp
  kcms/keyboard/tastenbrett/shape.h
  kcms/keyboard/tastenbrett/xkbobject.cpp
  kcms/keyboard/tastenbrett/xkbobject.h
  kcms/keyboard/tests/CMakeLists.txt
  kcms/keyboard/tests/geometry_parser_test.cpp
  kcms/keyboard/xkb_rules.cpp
  kcms/keyboard/xkb_rules.h

To: sitter, #plasma
Cc: davidre, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191115/fd4b3089/attachment-0001.html>


More information about the Plasma-devel mailing list