D25320: Show startup error in popup as well
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Nov 15 10:31:39 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
When the host crashes, the error message is shown to the user. When startup fails, only a generic message is shown.
This adds the error message provided by the browser to aid debugging the problem.
TEST PLAN
- Sabotaged my browser host, got the icon crossed-out, got "native host not found" in the popup. There was no badge because the icon is crossed out already and the error never cleared
- Fixed my host, got normal plasma icon with generic popup icon (no behavior change)
- Killed my host, got a "!" badge with the error which was cleared when the popup was closed (no behavior change)
F7764821: Screenshot_20191115_112629.png <https://phabricator.kde.org/F7764821>
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D25320
AFFECTED FILES
extension/action_popup.html
extension/action_popup.js
extension/extension.js
To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191115/9c3f2f1f/attachment.html>
More information about the Plasma-devel
mailing list