D24743: Update GTK settings according to Plasma settings

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> CMakeLists.txt:29
> +    ${GLIB2_LIBRARY}
> +    ${GTK3_LIBRARY}
> +    ${GOBJECT2_LIBRARY}

See below comments about GTK.

> configeditor.cpp:35
> +#include <gio/gio.h>
> +#include <gtk/gtk.h>
> +

You shouldn't need to import/use gtk for configuration, only gio which provides gsettings.

> configeditor.cpp:51
> +{
> +    gtk_init(nullptr, nullptr);
> +    g_autoptr(GSettings) gsettings = g_settings_new("org.gnome.desktop.interface");

You should probably remove this call here, as you aren't using any GTK functions.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191113/72caa905/attachment-0001.html>