D24743: Update GTK settings according to Plasma settings

[Nicolas Fella]

nicolasfella added a comment.


  Works really well, good job! Some minor nitpicks

INLINE COMMENTS

> CMakeLists.txt:69
>  add_subdirectory(tests)
> +add_subdirectory(kded-module)
>  

Nitpick, feel free to ignore since it was probably done by me:
usually we call the folder just 'kded'

> CMakeLists.txt:1
> +find_package(KF5DBusAddons)
> +

Move to top-level CMakeLists.txt (if needed at all)

> configeditor.cpp:176
> +{
> +    QProcess pidof {};
> +    pidof.start(QStringLiteral("pidof"), QStringList() << QStringLiteral("-s") << QStringLiteral("xsettingsd"));

QProcess pidof;

> configvalueprovider.cpp:53
> +    KIconTheme *newIconTheme = KIconLoader::global()->theme();
> +    if (newIconTheme == nullptr) {
> +        return QStringLiteral("breeze");

if (!newIconTheme)

> gtkconfig.cpp:24
> +#include <QFont>
> +#include <QtDBus/QDBusConnection>
> +#include <QGuiApplication>

#include <QDBusConnection>

> gtkconfig.json:4
> +        "Description": "GTK config management",
> +        "Icon": "preferences-system-power-management",
> +        "Name": "Plasma GTKd",

I know it was me who did this, but maybe "gtkconfig" as icon?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg, broulik, cblack
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191113/b4b2a950/attachment-0001.html>