D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

David Edmundson noreply at phabricator.kde.org
Wed Nov 13 14:35:40 GMT 2019


davidedmundson added inline comments.

INLINE COMMENTS

> handler.cpp:366-369
> +        Handler::updatePreviousBluetoothStatus();
>          m_tmpWirelessEnabled = NetworkManager::isWirelessEnabled();
>          m_tmpWwanEnabled = NetworkManager::isWwanEnabled();
>          enableBluetooth(false);

You're asynchronously querying the bluetooth state with multiple calls.
Afterwards we send a call to disable bluetooth.

DBus will maintain order of individual calls, but N async things vs N async things is less determined

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191113/ccec3058/attachment-0001.html>


More information about the Plasma-devel mailing list