D25284: Make QmlComponentsPool one instance per engine

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If we create 2 engines in an application the singleton is initialised to
  the first engine. If that first engine disappears the internal m_unit is
  dangling.
  
  A good example of this is systemsettings in the icon view if we enter
  two modules one after another. It's currently only kept alive because
  the sidebar created the first reference.
  
  BUG: 414003

TEST PLAN
  System settings in icon view
  opened global theme
  went back
  open fonts theme
  didn't crash

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25284

AFFECTED FILES
  src/columnview.cpp
  src/columnview_p.h

To: davidedmundson
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191113/3e24c2aa/attachment.html>