D25282: Ensure comments fetch for KNS starts on the right page
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Wed Nov 13 10:25:59 GMT 2019
leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.
REVISION SUMMARY
For a while, we've not had reviews/comments showing up for KNS content,
and ensures we initiate fetching from the correct page. It does not,
however, ensure that the number of reviews is quite correct, as
we will need to add support for replies in some way (even if it's
only done as an indication that they exist)
TEST PLAN
Without patch: Notice no reviews show up, except on very-reviewed items
With patch: Notice reviews show up on all content that says it has some
REPOSITORY
R134 Discover Software Store
BRANCH
start-fetching-kns-comments-from-the-right-page (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25282
AFFECTED FILES
libdiscover/backends/KNSBackend/KNSReviews.cpp
To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191113/88d21b21/attachment.html>
More information about the Plasma-devel
mailing list