D25212: Move the shortcut management in the settings object

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kcm.cpp:198
> This part appears to have gone?

Yes, it was never triggered. It turns out KKeySequenceWidget does that already as soon as you pick a new shortcut, so it could never end up conflicting here since said conflict would have been handled before.

> davidedmundson wrote in kscreensaversettings.cpp:46
> given we have defined the defaults at a kconfigskeleton level should we just call ->shortcut() here?

Not sure what you mean here. We're inside the KConfigSkeleton.

Note that KGlobalAccel seems to expect a first call to setShortcut to associate the local QAction with the information from KGlobalAccel. I admit KGlobalAccel looks like an odd beast to me.

> davidedmundson wrote in kscreensaversettings.cpp:48
> Could we handle the alternative shortcut by using a second property?

We could but it's not exposed in the KCM, not sure what the gain would be.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D25212

To: ervin, #plasma, davidedmundson, bport, crossi, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191112/489dc6e8/attachment.html>