D25263: [ComboBox] Don't dim Popup

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Nov 11 19:09:14 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The dimming only works with pure QML applications based on `ApplicationWindow` which is why it didn't do anything in System Settings. However, in Kirigami Gallery the entire window darkens unexpectedly.

TEST PLAN
  `ComboBox` in Kirigami gallery behaves normally now

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25263

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191111/7b0ac6a0/attachment.html>


More information about the Plasma-devel mailing list