D25205: Remove pointless QDBusServiceWatcher

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Nov 10 17:37:35 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> KSMServer.cpp:45
>  KSMServer::Private::Private(KSMServer *parent)
> -    : serviceWatcher(new QDBusServiceWatcher(this))
> -    , kwin(nullptr)
> +    : kwin(new QDBusInterface(KWIN_SERVICE, QStringLiteral("/KWin"), QStringLiteral("org.kde.KWin"), QDBusConnection::sessionBus(), this))
>      , processing(false)

This is also a perfect candidate for dbus xml?

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D25205

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191110/6909e643/attachment.html>


More information about the Plasma-devel mailing list