D25222: [Lock Screen] Fix album art binding loop

David Edmundson noreply at phabricator.kde.org
Sat Nov 9 14:25:46 GMT 2019


davidedmundson added inline comments.

INLINE COMMENTS

> MediaControls.qml:98
>              id: albumArt
>              Layout.preferredWidth: height
>              Layout.fillHeight: true

Aha, because of this!
A change in aspect ratio affects the width, which reloads the image, which changes the height, which changes the width

paintedWidth still seems wrong though, it'll only be evaluated after it loads the image at which point the sourceSize is too late.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25222

To: filipf, davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191109/02015fc6/attachment.html>


More information about the Plasma-devel mailing list