D25223: Avoid side effects during menu initialization

[Konrad Materka]

kmaterka added a comment.


  The problem was with:
  
    m_menu->setVisible(m_visible);
  
  setters/getters should not have side effects or any logic, but this method has. Detached menu stayed as top level window and rendered itself.
  
  VLC has a bug, each systray menu update creates new QMenu, but old one is not deleted:
  https://github.com/videolan/vlc/blob/master/modules/gui/qt/menus.cpp#L655
  
  QMenu::clear() deletes all attached actions (if not used somewhere else) but not menus! It is weird, but someone explained it here:
  https://bugreports.qt.io/browse/QTBUG-11070

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191108/aff97b33/attachment.html>