D25205: Remove pointless QDBusServiceWatcher

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KActivitymanagerd's ksmserver has a QDBusServiceWatcher in order to
  recreate a QDBusInterface when the service goes away. There is no need
  to do this, a call to a given method to a given service will work
  regardless, dispatching to the correct client is all internal to
  dbus-daemon.
  
  QDBusAbstractInterface has it's own internal QDBusServiceWatcher anyway
  so we don't get any behavioural differences if we check isValid.
  
  This is worth fixing as this class is moved threads and we end up with
  newly created children in a mess.
  
  CCBUG: 413940

TEST PLAN
  Compiles. I probably need to run with it for a week or so
  and switch activities a bit before merging

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25205

AFFECTED FILES
  src/service/ksmserver/KSMServer.cpp
  src/service/ksmserver/KSMServer_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191108/50446b71/attachment.html>