D25020: fix: create control files only when needed

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> control.cpp:224
>  {
> -    const QString dir = dirPath() % QStringLiteral("outputs/");
> -    if (!QDir().mkpath(dir)) {
> -        return QString();
> -    }
> -    return dir % hash;
> +    return Control::dirPath() % QStringLiteral("outputs/");
>  }

who would now makes this folder?

ControlConfig has a line to do so, but ControlOutput does not.

I can't see a line in config.cpp (though I'm not 100% sure where ControlOutput is currently used)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D25020

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191107/186514ae/attachment.html>