D25196: Perform KNS searches from the Featured page again

Aleix Pol Gonzalez noreply at phabricator.kde.org
Thu Nov 7 19:00:28 GMT 2019


apol added a comment.


  How about we target master for this?

INLINE COMMENTS

> KNSBackend.cpp:507
>          return stream;
> -    } else if ((m_hasApplications && !filter.category) // If there is no category defined, we are searching in the root, and should include only application results
> +    } else if ((!filter.category && !filter.search.isEmpty()) // Accept KNS searches from the Featured page
>                // If there /is/ a category, make sure we actually are one of those requested before searching

The comment should be `//Accept global searches`, the featured page queries by URL.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25196

To: ngraham, apol, #discover_software_store
Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191107/d80167ec/attachment.html>


More information about the Plasma-devel mailing list