D25178: Switch ToolBarPageHeader to use the icon collapse behaviour from ActionToolBar

Arjen Hiemstra noreply at phabricator.kde.org
Wed Nov 6 18:48:05 GMT 2019


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This removes the icon collapse behaviour of ToolBarPageHeader in favour
  of the implementation that is now implemented in ActionToolBar. It also
  fixes a small performance regression that was introduced with the action
  overflow behaviour.
  
  Depends on D25177 <https://phabricator.kde.org/D25177>

TEST PLAN
  Kirigami Gallery still shows actions, the main/left/right actions change to
  icons at the appropriate moments.

REPOSITORY
  R169 Kirigami

BRANCH
  iconcollapse_toactiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D25178

AFFECTED FILES
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191106/7c39186b/attachment-0001.html>


More information about the Plasma-devel mailing list