D25175: FormLayout: Fix label height if wide mode is false

Jonah BrĂ¼chert noreply at phabricator.kde.org
Wed Nov 6 16:50:30 GMT 2019


jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  previously the height of the label was based on the content's height. However this doesn't work in non wide mode. With this change it preserves the previous behaviour in wide mode were it makes sense but uses a constant height in non-wide mode.

TEST PLAN
  FormLayouts with large content items don't have large margins between the items anymore when wideMode = false.

REPOSITORY
  R169 Kirigami

BRANCH
  fix/formlayout-label-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25175

AFFECTED FILES
  src/controls/FormLayout.qml

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191106/787077de/attachment.html>


More information about the Plasma-devel mailing list