D24865: [SystemTray] Support for AttentionIcon

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Alternative below. IMHO it might be cleaner.
  
  Otherwise, this is fine.

INLINE COMMENTS

> kmaterka wrote in StatusNotifierItem.qml:52
> I know... Do you know another way how to check if QVariant(QIcon) is null? I know that I can create simple native method in systemtray.cpp for that - will it be better?

The easiest alternative is to do it earlier in the source itself.

Instead of supplying a valid QVariant with a null icon, we can export a null QVariant.

i.e statusnotifiericonsource.cpp
90: setData(QStringLiteral("AttentionIcon"), QVariant());
332: QStringLiteral("AttentionIcon"), attentionIcon.isNull() ? QVariant(), attentionIcon);

Then the regular QML tests will work just fine.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24865

To: kmaterka, #plasma, broulik, #plasma_workspaces, davidedmundson
Cc: lbeltrame, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191105/9a464eff/attachment.html>