D25074: Disable the restore defaults button if the KCModule says so

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ModuleView.cpp:427
>      d->mHelp->setEnabled(buttons & KCModule::Help );
> -    d->mDefault->setEnabled(buttons & KCModule::Default );
>  }

Not saying this is wrong, but can you explain this change?

In https://phabricator.kde.org/D25072

we do setEnabled((buttons & Default) && !defaulted) rather than changing visibility, presumably it's there to make sure buttons don't move as you navigate between modules.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25074

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191104/027199c4/attachment.html>