D21514: MobileTextActionsToolBar: fix runtime warnings when controlRoot isn't set yet

David Faure noreply at phabricator.kde.org
Fri May 31 18:28:09 BST 2019


dfaure created this revision.
dfaure added reviewers: mart, apol, broulik.
Herald added a project: Plasma.
dfaure requested review of this revision.

REVISION SUMMARY
  This file checks for controlRoot being undefined, everywhere else.

TEST PLAN
  `qmlscene tests/testComboBox.qml` showed
  MobileTextActionsToolBar.qml:62: TypeError: Cannot read property 'selectedText' of null
  MobileTextActionsToolBar.qml:70: TypeError: Cannot read property 'selectedText' of null
  MobileTextActionsToolBar.qml:78: TypeError: Cannot read property 'canPaste' of null

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  2019_fix_MobileTextActionsToolBar_warnings

REVISION DETAIL
  https://phabricator.kde.org/D21514

AFFECTED FILES
  org.kde.desktop/private/MobileTextActionsToolBar.qml

To: dfaure, mart, apol, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190531/7715f149/attachment-0001.html>


More information about the Plasma-devel mailing list