D21473: [Notifications] Don't replace last one if next one is identical

Kai Uwe Broulik noreply at phabricator.kde.org
Wed May 29 08:32:02 BST 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since there is timeout for when it is considered a separate notification and we don't even close the previous one properly.
  Just remove that stopgap and if we need something like this again, do it properly.

TEST PLAN
  It was mostly to keep VLC from spamming me but has other implications like being unable to remove two identical widgets in a row in Plasma as the second undo notification replaces the first, even after minutes (if no notification happened inbetween)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21473

AFFECTED FILES
  libnotificationmanager/notificationsmodel.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190529/994c5872/attachment-0001.html>


More information about the Plasma-devel mailing list