D21417: [ActionListItem] Make QML imports and tooltip consistent

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon May 27 19:18:03 BST 2019


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Otherwise it's good to go.

INLINE COMMENTS

> ActionListItem.qml:44
>  
> -    ToolTip.visible: hovered
> -    ToolTip.text: action.shortcut ? action.shortcut : p0.nativeText
> +        readonly property var tooltip: QQC2.ToolTip {
> +            text: action.shortcut ? action.shortcut : p0.nativeText

It has an indentation too much.

REPOSITORY
  R134 Discover Software Store

BRANCH
  actionlistitem-make-qml-imports-and-tooltip-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21417

To: GB_2, #plasma, #vdg, apol
Cc: apol, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190527/22506264/attachment-0001.html>


More information about the Plasma-devel mailing list