D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added inline comments.

INLINE COMMENTS

> broulik wrote in AbstractItem.qml:22
> You sure this high version number is neccessary?

Not exactly. But old layouts used to have a load of restrictions, for sure.

> broulik wrote in AbstractItem.qml:30
> Avoid doing negated disjunctions for clarity: `!labelVisible && !vertical`

Oh, give it a rest.  These two lines looking good together, this way it is clear that they are an opposite of each other.

> broulik wrote in AbstractItem.qml:74
> For some reason the icons are now smaller than they were before, observed on two separate computers, they used to be the same as the panel icon here:
> F6849506: Screenshot_20190525_191014.png <https://phabricator.kde.org/F6849506>

Not even sure, is it directly my mistake, or rebase on that later master branch. Could you provide more specific numbers, please?

> broulik wrote in AbstractItem.qml:130
> Can you just make the `iconItem` have a `anchors.fill: parent`?

maaayyybe...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190527/56215e0b/attachment.html>