D21423: [Notifications] Don't show blue icon when a notification is active

Kai Uwe Broulik noreply at phabricator.kde.org
Mon May 27 08:58:15 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Also consider a notification as unread only when it isn't active anymore.

TEST PLAN
  `notify-send foo bar`, waited for popup to close, got a "1" in my panel
  `notify-send foo bar`, closed the popup, didn't get anything in my panel
  As suggested by VDG
  
  I originally had the notification plasmoid show up alongside the popup to kinda indicate "this is where this thing is coming from/going to". With this change the notification plasmoid will not be shown in the panel unless there is an unread notification.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21423

AFFECTED FILES
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  libnotificationmanager/notifications.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190527/b50e1e96/attachment-0001.html>


More information about the Plasma-devel mailing list