D21365: [Notifications] Avoid stale screenRect

Kai Uwe Broulik noreply at phabricator.kde.org
Thu May 23 13:50:18 BST 2019


broulik created this revision.
broulik added reviewers: Plasma, mart, lbeltrame, dvratil.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `AppletInterface` does not emit change signals for screen properties, only `ContainmentInterface` does it.
  Since a fix will only be in a future version 5.16 won't depend on, mitigate the effect by not caching the property.
  The property was only a lazy `Connections` replacement anyway.
  Also, compress screen change updates to avoid flickery animation of the popup as you resize the panel.
  
  CCBUG: 407504
  BUG: 399257

TEST PLAN
  For some reason all of this used to work two weeks ago but I tried going back to an older p-w and p-f to no avail...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21365

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, mart, lbeltrame, dvratil
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190523/c7594204/attachment.html>


More information about the Plasma-devel mailing list