D21326: Make limtedrowcountproxymodel usable from QML

[Kai Uwe Broulik]

broulik added a comment.


  Before moving to frameworks also needs d-pointer

INLINE COMMENTS

> limitedrowcountproxymodel_p.h:47
> +     *
> +     * The default value is 0
> +     */

Should we use `-1` as the default instead and have 0 actually mean limit of zero items = empty?

> limitedrowcountproxymodel_p.h:54
>      void limitChanged();
> +    void sourceModelChanged();
>  

Move above `limitChanged` so the order is consistent with the setter

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21326

To: davidedmundson, #plasma
Cc: broulik, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190523/94cb304d/attachment.html>