D20585: [FormLayout] Use even top and bottom spacing for separator

Filip Fila noreply at phabricator.kde.org
Tue May 21 22:34:22 BST 2019


filipf added a comment.


  In D20585#465924 <https://phabricator.kde.org/D20585#465924>, @mart wrote:
  
  > I don't like adding a new property to separator for doing duck typing...
  >
  > even is really ugly and errorprone as well, but i would prefer 
  >  Layout.topMargin: item.toString().indexOf("Separator")===0 ? Kirigami.Units.smallSpacing : 0
  >
  > with a comment:
  >  // FIXME: use item instanceof Kirigami.Separator when we can depend from Qt 5.11
  
  
  This doesn't work, but I will try to tinker with it.
  
  F6841616: image.png <https://phabricator.kde.org/F6841616>

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D20585

To: filipf, mart, #kirigami, ngraham
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190521/1a2e192f/attachment.html>


More information about the Plasma-devel mailing list