Review Request: plasma-thunderbolt
Jonathan Riddell
jr at jriddell.org
Tue May 21 09:15:38 BST 2019
On Wed, May 15, 2019 at 03:27:07PM +0200, Daniel Vrátil wrote:
> plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM
> for Plasma. I initially submitted the code as a patch against plasma-desktop
> [0], where it got reviewed, but it was ultimately decided to better put it
> into a separate repository, since it's not just a KCM but also a library and a
> KDED module. I have backported all the changes from the Phabricator review
> back to the repository, so the code in the repo is identical to the one in the
> Phab review (minus buildsystem changes and a small build fix for clang).
>
> However, since this is still a new code, it must formally pass through
> kdereview before I can submit it into Plasma as a new module.
>
> Thus I'd kindly ask you to take one more look at the codebase [1] and let me
> know if there are any more issues to fix, or if we can proceed to include this
> in the next Plasma release.
Installing the bolt package on Debian/Ubuntu/KDE neon I have this file
/usr/lib/x86_64-linux-gnu/boltd
But it is not found by FindBolt.cmake
I need to add this to the search path ${LIB_INSTALL_DIR}
Looks great but I don't have anything Thunderbolt so it's just a white box :)
Jonathan
More information about the Plasma-devel
mailing list