D21307: Optimise the NetworkModel

Jan Grulich noreply at phabricator.kde.org
Mon May 20 19:03:38 BST 2019


jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good.

INLINE COMMENTS

> networkmodelitem.cpp:561
>          if (m_mode == NetworkManager::WirelessSetting::Infrastructure) {
> -            m_details << i18n("Signal strength") << QString("%1%").arg(m_signal);
> +            m_details << i18n("Signal strength") << QString::number(m_signal);
>          }

This will remove the '%' at the end of signal strength.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21307

To: apol, #plasma, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190520/6adbf9b1/attachment-0001.html>


More information about the Plasma-devel mailing list