D21269: [Touchpad KCM] Fixed loading of wrong qml file
Atul Bisht
noreply at phabricator.kde.org
Sat May 18 11:58:03 BST 2019
atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.
REVISION SUMMARY
On system settings, If Mouse KCM is opened first, then touchpad KCM loads the same Mouse QML file (qrc::/libinput/main.qml) instead of Touchpad Qml file.
Having same url (qrc::/libinput/main.qml).
Fix: simply renaming qml files fixed the issue.There could be better solutions though.
TEST PLAN
1. Renamed main.qml to touchpad.qml .
2. Edited resource file to reflect change.
3. When compiled with these changes and opened touchpad setting, it was all blank, which was expected (because i did not changed the source).But opening mouse and then
touchpad shows mouse settigs. So it Confirmed the cause.
4. Now changing source and compiling it fixes the issue. Now, no more mouse on Touchpad and vice-versa.
REPOSITORY
R119 Plasma Desktop
BRANCH
touchpad-mouse
REVISION DETAIL
https://phabricator.kde.org/D21269
AFFECTED FILES
kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
kcms/touchpad/src/kcm/libinput/main.qml
kcms/touchpad/src/kcm/libinput/touchpad.qml
kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
kcms/touchpad/src/kcm/resources.qrc
To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190518/7de8efe6/attachment-0001.html>
More information about the Plasma-devel
mailing list