D21228: [Touchpad KCM] Load previous setting on reboot

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> libinputtouchpad.cpp:217
> +    KSharedConfigPtr configPtr = KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc"));
> +    m_config = configPtr.data();
> +    touchpadConfig = m_config->group(m_name);

This can be left dangling

Store the KSharedConfigPtr as the member variable then you'll keep a reference

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190515/204da14c/attachment.html>