D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Discover uses the `Kirigami.GlobalDrawer` for its navigation sidebar. This component is
  designed to be used for showing global actions and hiding when not in use, and displays
  a big banner image on top. This banner concept is borrowed from Android, which has the
  same kind of global drawers full of actions with banners on top. So the concept is
  somewhat familiar on mobile. However on the desktop, this "sidebar with banner image on
  top" UI is not used and feels out of place.
  
  This patch adjusts the sidebar appearance to look and feel more conventional in the
  desktop view, keeping the banner version only for the mobile view.

TEST PLAN
  Desktop view: F6826087: Desktop view.png <https://phabricator.kde.org/F6826087>
  Mobile view: F6826086: Mobile view.png <https://phabricator.kde.org/F6826086>
  
  Now Discover's sidebar looks quite similar to System Settings' sidebar, which is very
  visually appealing: F6826091: Discover and System Settings.png <https://phabricator.kde.org/F6826091>

REPOSITORY
  R134 Discover Software Store

BRANCH
  more-conventional-sidebar-header-appearance

REVISION DETAIL
  https://phabricator.kde.org/D21234

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190515/8b9488c2/attachment.html>