D19745: Fix system tray UI/UX & refactor

ivan tkachenko noreply at phabricator.kde.org
Wed May 15 12:43:26 BST 2019


ratijastk added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:66
> Not really.
> Using objectNames is a bit of an anti pattern, especially when QML has so the built-in component scope hierachy.
> 
> We use it in the system tray already, and it's arguably no worse than the existing applet.parent.parent.
> 
> So fine here, but only because the system is mad.

Pattern or not — Qt provides us with this `objectName` property so we can do stuff. But Qt itself is not engaged in providing further support for it. That's frustrating.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190515/2c57f564/attachment-0001.html>


More information about the Plasma-devel mailing list