D14147: Port from GConf to GSettings

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue May 14 19:53:30 BST 2019


kossebau added inline comments.

INLINE COMMENTS

> FindGIO.cmake:20
> +    include(UsePkgConfig)
> +    pkgconfig(gio-2.0 _LibGIOIncDir _LibGIOLinkDir _LibGIOLinkFlags _LibGIOCflags)
> +endif(NOT WIN32)

It seems `_LibGIOLinkFlags`, `_LibGIOLinkDir` & `_LibGIOCflags` are not propagated  into the build. So if e.g. the libraries are not in default lib dir, linking will fail, cmp. https://build.kde.org/view/Failing/job/Plasma/job/plasma-pa/job/kf5-qt5%20FreeBSDQt5.12/18/

Please give this another look & also compare with other pkgconfig() using Find' macros.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: fvogt, kossebau, ngraham, pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190514/3fc79305/attachment-0001.html>


More information about the Plasma-devel mailing list